Fix SSO Login when JWT_PRIVATE_SIGNING_JWK is not set - #20160
Conversation
1b9ea30 to
56cfbd0
Compare
|
Should these commits be on master? |
|
@nedbat um.. Was gonna ask you this morning. Which ironwood branch should this PR be against? |
32ae2a7 to
16ae603
Compare
|
@nedbat Can you take a look at the failing bokchoy tests? Are there Ironwood configuration settings for Studio Documentation links that need to be updated? |
|
jenkins run bokchoy https://build.testeng.edx.org/job/ironwood-bokchoy-pipeline-pr/25/ |
16ae603 to
71b47af
Compare
|
Your PR has finished running tests. The following contexts failed:
|
|
@nedbat The current Bokchoy failures are related to Studio Help Navigation Links. It seems the tests don't pass when the RELEASE_LINE is set to I recommend we move forward with merging this change. We can address the unrelated Bokchoy tests at a later time. Can you please review and confirm that we should merge into ironwood.master? Thanks. |
|
@nasthagiri Yes, the bokchoy failures are not an issue (though I added skips specifically so these failures wouldn't happen, not sure why the tests are still running...) |
|
Oh: you didn't make this commit on the tip of ironwood. My test fixes are after the commit you based this on. No worries. |
3 participants
This PR fixes the Ironwood workaround introduced in https://github.com/edx/edx-platform/pull/19674.
In particular, the earlier PR avoids the need for Open edX Ironwood installations to set up their Private JWKs. It does this by bypassing the creation of JWT Cookies when its required key configuration is missing. However, this bypass check was also needed in an additional place, which this PR fixes.